[PATCH v3 7/9] hyperv: fix domainSuspend and domainResume on Hyper-V V2
Michal Privoznik
mprivozn at redhat.com
Wed Oct 21 11:01:39 UTC 2020
On 10/21/20 11:40 AM, Matt Coleman wrote:
>> On Oct 21, 2020, at 4:46 AM, Matt Coleman <mcoleman at datto.com> wrote:
>>
>> + int requestedState;
>
> This caused GitLab CI failures that didn't happen on my local builds.
>
> This should be squashed in...
> ===================================================================
> --- src/hyperv/hyperv_driver.c (revision 156ebef03c01146a0bab294a0db8f3bd2f707d96)
> +++ src/hyperv/hyperv_driver.c (revision 37c994da34f77d41a06f75e4d1272b671dd16b94)
> @@ -891,7 +891,7 @@
> int result = -1;
> hypervPrivate *priv = domain->conn->privateData;
> Msvm_ComputerSystem *computerSystem = NULL;
> - int requestedState;
> + int requestedState = -1; /* dummy value: this must be set later in the function */
>
> switch (priv->wmiVersion) {
> case HYPERV_WMI_VERSION_V1:
> @@ -926,7 +926,7 @@
> int result = -1;
> hypervPrivate *priv = domain->conn->privateData;
> Msvm_ComputerSystem *computerSystem = NULL;
> - int expectedState;
> + int expectedState = -1; /* dummy value: this must be set later in the function */
>
> switch (priv->wmiVersion) {
> case HYPERV_WMI_VERSION_V1:
>
>
I don't think these comments are necessary. All init values are dummy
and must be set later in the function :-)
Michal
More information about the libvir-list
mailing list