[PATCH v3 3/9] hyperv: implement domainSetAutostart
Matt Coleman
mcoleman at datto.com
Wed Oct 21 11:15:20 UTC 2020
> On Oct 21, 2020, at 7:01 AM, Michal Privoznik <mprivozn at redhat.com> wrote:
>
> On 10/21/20 10:46 AM, Matt Coleman wrote:
>>
>> + if (hypervInvokeMethod(priv, ¶ms, NULL) < 0) {
>> + virReportError(VIR_ERR_INTERNAL_ERROR, "%s", _("Could not set autostart"));
>
> No need to report error here because hypervInvokeMethod() already reported one for us. And unfortunately we don't have stacked error messages, so this would just overwrite the error reported earlier.
I keep forgetting that this overwrites any previously-reported error. Feel free to remove this, or I can do it in a later commit.
--
Matt
More information about the libvir-list
mailing list