[PATCH 1/2] parthelper: Initialize error object

Michal Privoznik mprivozn at redhat.com
Thu Oct 22 11:01:49 UTC 2020


Some functions called from parthelper can report an error. But
that means that the error object must be initialized otherwise
virResetError() (which happens as a part of virReportError())
will free random pointers.

Reported-by: Katerina Koukiou <kkoukiou at redhat.com>
Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/storage/parthelper.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/storage/parthelper.c b/src/storage/parthelper.c
index 812e90d3cb..29a01d3dd5 100644
--- a/src/storage/parthelper.c
+++ b/src/storage/parthelper.c
@@ -66,7 +66,8 @@ int main(int argc, char **argv)
     const char *partsep;
     bool devmap_partsep = false;
 
-    if (virGettextInitialize() < 0)
+    if (virGettextInitialize() < 0 ||
+        virErrorInitialize() < 0)
         exit(EXIT_FAILURE);
 
     if (argc == 3 && STREQ(argv[2], "-g")) {
-- 
2.26.2




More information about the libvir-list mailing list