[PATCH 10/15] Replace all instances of 'virHashCreate' with 'virHashNew'

Pavel Hrdina phrdina at redhat.com
Thu Oct 22 11:43:09 UTC 2020


On Thu, Oct 22, 2020 at 11:35:01AM +0200, Peter Krempa wrote:
> It doesn't make much sense to configure the bucket count in the hash
> table for each case specifically. Replace all calls of virHashCreate
> with virHashNew which has a pre-set size and remove virHashCreate
> completely.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/conf/domain_addr.c                    |  2 +-
>  src/conf/domain_conf.c                    |  4 ++--
>  src/conf/virchrdev.c                      |  2 +-
>  src/conf/virdomainmomentobjlist.c         |  2 +-
>  src/conf/virdomainobjlist.c               |  4 ++--
>  src/conf/virinterfaceobj.c                |  2 +-
>  src/conf/virnetworkobj.c                  |  5 ++---
>  src/conf/virnodedeviceobj.c               |  2 +-
>  src/conf/virnwfilterbindingobjlist.c      |  2 +-
>  src/conf/virsecretobj.c                   |  2 +-
>  src/conf/virstorageobj.c                  | 10 +++++-----
>  src/hyperv/hyperv_wmi.c                   |  2 +-
>  src/hypervisor/virclosecallbacks.c        |  2 +-
>  src/libvirt_private.syms                  |  1 -
>  src/libxl/libxl_logger.c                  |  2 +-
>  src/locking/lock_daemon.c                 |  8 ++------
>  src/nwfilter/nwfilter_dhcpsnoop.c         |  6 +++---
>  src/nwfilter/nwfilter_ebiptables_driver.c |  4 ++--
>  src/nwfilter/nwfilter_gentech_driver.c    |  2 +-
>  src/nwfilter/nwfilter_learnipaddr.c       |  4 ++--
>  src/qemu/qemu_block.c                     |  6 +++---
>  src/qemu/qemu_capabilities.c              |  4 ++--
>  src/qemu/qemu_driver.c                    |  2 +-
>  src/qemu/qemu_interop_config.c            |  2 +-
>  src/qemu/qemu_monitor.c                   | 10 +++++-----
>  src/qemu/qemu_monitor_json.c              |  2 +-
>  src/qemu/qemu_qapi.c                      |  2 +-
>  src/rpc/virnetdaemon.c                    |  2 +-
>  src/security/security_selinux.c           |  4 ++--
>  src/util/virfilecache.c                   |  2 +-
>  src/util/virhash.c                        | 21 ---------------------
>  src/util/virhash.h                        |  2 --
>  src/util/viriptables.c                    |  4 ++--
>  src/util/virlockspace.c                   |  6 ++----
>  src/util/virmacmap.c                      |  2 +-
>  src/util/virstoragefile.c                 |  4 ++--
>  src/util/virsystemd.c                     |  2 +-
>  tests/qemumonitorjsontest.c               | 10 +++++-----
>  tests/qemusecuritymock.c                  |  4 ++--
>  tests/testutilsqemu.c                     |  2 +-
>  tests/virhashtest.c                       |  8 ++++----
>  41 files changed, 69 insertions(+), 100 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201022/3533d111/attachment-0001.sig>


More information about the libvir-list mailing list