[External] Re: [PATCH v3 0/2]support memory failure

[zhenwei pi]

On 10/23/20 1:00 AM, Michal Privoznik wrote:
> On 10/14/20 12:37 PM, zhenwei pi wrote:
>> v2->v3:
>>      Rework patches to make each patch could be compiled,
>>
>> v1->v2:
>>      Seperate a 'all in one' patch into 4 patches.
>>      Use a 'flags' with bit definition instead of 'action_required'
>>          & 'recursive' for extention.
>>      Queue event directly without internal job.
>>      Add full test method in commit.
>>
>> v1:
>> Since QEMU 5.2 (commit-77b285f7f6), QEMU supports 'memory failure'
>> event, posts event to monitor if hitting a hardware memory error.
>> zhenwei pi (2):
>>    libvirt: support memory failure event
>>    qemu: implement memory failure event
>>
>>   include/libvirt/libvirt-domain.h    | 82 
>> +++++++++++++++++++++++++++++++++++++
>>   src/conf/domain_event.c             | 80 
>> ++++++++++++++++++++++++++++++++++++
>>   src/conf/domain_event.h             | 12 ++++++
>>   src/libvirt_private.syms            |  2 +
>>   src/remote/remote_daemon_dispatch.c | 32 +++++++++++++++
>>   src/remote/remote_driver.c          | 32 +++++++++++++++
>>   src/remote/remote_protocol.x        | 16 +++++++-
>>   src/remote_protocol-structs         |  8 ++++
>>   examples/c/misc/event-test.c        | 16 ++++++++
>>   tools/virsh-domain.c                | 40 ++++++++++++++++++
>>   src/qemu/qemu_monitor.c             | 21 +++++++++-
>>   src/qemu/qemu_monitor.h             | 39 ++++++++++++++++++
>>   src/qemu/qemu_monitor_json.c        | 49 ++++++++++++++++++++++
>>   src/qemu/qemu_process.c             | 59 ++++++++++++++++++++++++++
>>   14 files changed, 486 insertions(+), 2 deletions(-)
>>
> 
> Sorry for not replying earlier, had this marked for review but got 
> sidetracked with some other work.
> 
> Patches look good to me, but I'm suggesting couple of fixups. If you 
> agree with them I can put my reviewed by tag and merge them.
> 
> Michal
> 

I agree with these changes. Thanks a lot.

-- 
zhenwei pi