[PATCH 0/4] hyperv: Deduplicate and reformat

Neal Gompa ngompa13 at gmail.com
Fri Oct 23 14:55:41 UTC 2020


On Fri, Oct 23, 2020 at 10:53 AM Neal Gompa <ngompa13 at gmail.com> wrote:
>
> On Wed, Oct 21, 2020 at 11:45 AM Michal Privoznik <mprivozn at redhat.com> wrote:
> >
> > The more I look into the code the more things to fix I find. Well, here
> > are some fixes.
> >
> > Michal Prívozník (4):
> >   hyperv: Don't overwrite errors from hypervCreateInvokeParamsList()
> >   hyperv: Use hypervRequestStateChange() in hypervDomainSuspend()
> >   hyperv: Use two empty lines between functions
> >   hyperv: Reformat
> >
> >  src/hyperv/hyperv_driver.c | 186 +++++++++---------------
> >  src/hyperv/hyperv_util.c   |   1 -
> >  src/hyperv/hyperv_wmi.c    | 288 +++++++++++++++++++------------------
> >  src/hyperv/hyperv_wmi.h    |  15 +-
> >  4 files changed, 229 insertions(+), 261 deletions(-)
> >
> > --
> > 2.26.2
> >
>
> Series LGTM.
>
> Reviewed-by: Neal Gompa <ngompa13 at gmail.com>
>
> But... uhh... there's also this series from Matt Coleman, which I just
> reviewed: https://www.redhat.com/archives/libvir-list/2020-October/msg01282.html
>
> Can we put the two together somehow?
>

Ignore me, apparently this was seen by him already (his review was in spam...)



-- 
真実はいつも一つ!/ Always, there's only one truth!





More information about the libvir-list mailing list