[PATCH v2 2/7] migration/dirtyrate: Implement qemuMonitorJSONExtractDirtyRateInfo

Peter Krempa pkrempa at redhat.com
Mon Oct 26 06:24:26 UTC 2020

On Sun, Oct 25, 2020 at 10:35:03 +0800, Hao Wang wrote:
> Hi Daniel,
> For the warning in your compiling -- "error: ‘qemuMonitorJSONExtractDirtyRateInfo’ defined but not used [-Werror=unused-function]":
> " qemuMonitorJSONExtractDirtyRateInfo" would be called by function "qemuMonitorJSONQueryDirtyRate" in [PATCH 3/7].
> So please apply all the serial of patches before your compiling. Thanks!

Note that according to our contributor guidelines [1] a patchset must
compile cleanly and pass all testsuite after every single patch.

Please reorganize your series such that this can be achieved. Also note
that squashing all patches into 1 is not acceptable. Patchet must be
logically split into separable chunks.

[1] https://libvirt.org/hacking.html#preparing-patches

More information about the libvir-list mailing list