[PATCH v2] news: introduce memory failure event

Michal Privoznik mprivozn at redhat.com
Mon Oct 26 08:12:36 UTC 2020


On 10/23/20 3:53 PM, zhenwei pi wrote:
> Signed-off-by: zhenwei pi <pizhenwei at bytedance.com>
> ---
>   NEWS.rst | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/NEWS.rst b/NEWS.rst
> index d0454b7840..428928e80b 100644
> --- a/NEWS.rst
> +++ b/NEWS.rst
> @@ -13,6 +13,16 @@ v6.9.0 (unreleased)
>   
>   * **New features**
>   
> +  * Introduce memory failure event
> +
> +    Libvirt could handle domain's memory failure event. Drivers need to
> +    implement their own method.

In my opinion this is unnecessary. The target audience of this file is 
users, not developers so much. Therefore, the second sentence does not 
add much value, because: a) users don't know how to implement that 
(unless an user is also a developer), b) by this time, users should be 
used to our driver model and the fact that some drivers implement a 
feature that other drivers don't (yet).

> +
> +  * qemu: Implement memory failure event
> +
> +    New event is implemented that is emitted whenever a guest encounters a
> +    memory failure.
> +

ACK to this hunk and pushed.

Thanks for handling this.

Michal




More information about the libvir-list mailing list