[PATCH 1/2] qemu: Don't try to start NBD server twice

Peter Krempa pkrempa at redhat.com
Mon Oct 26 11:50:32 UTC 2020

On Mon, Oct 26, 2020 at 11:41:35 +0100, Michal Privoznik wrote:
> In one of recent patches the way that we start NBD server for
> incoming migration was reworked (v6.8.0-rc1~298). A new boolean
> was introduced that tracks whether the NBD server was started so
> that we don't start it twice nor record in the port in the port
> allocator twice. Well, this idea is good, but in the
> implementation the boolean is never set, so we are reserving the
> port twice and would be starting the NBD server twice too if it
> wasn't for port reservation fail.
> Fixes: e74d627bb3bc2684cbe3edc1e2f7cc745b4e1ff3
> Reported-by: Vjaceslavs Klimovs <vklimovs at gmail.com>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_migration.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Reviewed-by: Peter Krempa <pkrempa at redhat.com>

More information about the libvir-list mailing list