[PATCH] qemu: Add test cases for 'host_cdrom' blockdev backend via <disk>

Ján Tomko jtomko at redhat.com
Mon Oct 26 16:10:24 UTC 2020


On a Monday in 2020, Peter Krempa wrote:
>Simulate that the device is a cdrom when the path equals to /dev/cdrom
>to provide testing for the 'host_cdrom' backend.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
>
>I've already posted this before but I mistakenly identified is as wrong
>and self-NACKed it, but we don't really have a test for a <disk
>type=cdrom> backed by a host device, so this patch makes sense.
>
> tests/qemuxml2argvdata/disk-cdrom.args               |  4 ++--
> tests/qemuxml2argvdata/disk-cdrom.x86_64-2.12.0.args |  4 ++--
> tests/qemuxml2argvdata/disk-cdrom.x86_64-latest.args |  6 +++---
> tests/qemuxml2argvdata/disk-cdrom.xml                |  5 +++--
> tests/qemuxml2argvtest.c                             | 11 +++++++++++
> tests/qemuxml2xmloutdata/disk-cdrom.xml              |  5 +++--
> 6 files changed, 24 insertions(+), 11 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20201026/8cfddbf0/attachment-0001.sig>


More information about the libvir-list mailing list