[libvirt PATCH v2 10/10] rpc: use new virt-ssh-helper binary for remote tunnelling

[Andrea Bolognani]

On Fri, 2020-07-24 at 18:22 +0200, Andrea Bolognani wrote:
> On Fri, 2020-07-24 at 16:14 +0100, Daniel P. Berrangé wrote:
> >  char *
> > +virNetClientSSHHelperCommand(virNetClientProxy proxy,
> > +                             const char *netcatPath,
> > +                             const char *socketPath,
> > +                             const char *driverURI,
> > +                             bool readonly)
> > +{
> [...]
> > +    switch (proxy) {
> > +    case VIR_NET_CLIENT_PROXY_AUTO:
> > +        return g_strdup_printf("sh -c 'which virt-nc 1>/dev/null 2>&1; "
> > +                               "if test $? = 0; then "
> > +                               "    %s; "
> > +                               "else"
> > +                               "    %s; "
> > +                               "fi'", helpercmd, nccmd);
> 
> s/virt-nc/virt-ssh-helper/

It appears that you forgot to fix this before pushing, and so 6.8.0
was released with broken detection which causes it to only ever use
virt-ssh-helper when forced through URI parameters.

I have prepared the obvious fix[1], can you please ACK it so that we
can release 6.9.0 with the feature working as intended? Thanks!


[1] https://www.redhat.com/archives/libvir-list/2020-October/msg01410.html
-- 
Andrea Bolognani / Red Hat / Virtualization