[PATCH v6 04/11] nbd: Update qapi to support exporting multiple bitmaps

Peter Krempa pkrempa at redhat.com
Tue Oct 27 12:37:13 UTC 2020


On Tue, Oct 27, 2020 at 00:05:49 -0500, Eric Blake wrote:
> Since 'block-export-add' is new to 5.2, we can still tweak the
> interface; there, allowing 'bitmaps':['str'] is nicer than
> 'bitmap':'str'.  This wires up the qapi and qemu-nbd changes to permit
> passing multiple bitmaps as distinct metadata contexts that the NBD
> client may request, but the actual support for more than one will
> require a further patch to the server.
> 
> Note that there are no changes made to the existing deprecated
> 'nbd-server-add' command; this required splitting the QAPI type
> BlockExportOptionsNbd, which fortunately does not affect QMP
> introspection.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  docs/system/deprecated.rst |  3 ++-
>  qapi/block-export.json     | 41 +++++++++++++++++++++++++++-----------
>  blockdev-nbd.c             |  6 +++++-
>  nbd/server.c               | 19 ++++++++++++------
>  qemu-nbd.c                 | 18 ++++++++---------
>  5 files changed, 58 insertions(+), 29 deletions(-)

Reviewed-by: Peter Krempa <pkrempa at redhat.com>




More information about the libvir-list mailing list