[PATCH 10/12] util: remove unused VIR_DIR_CLOSE() macro

Laine Stump laine at redhat.com
Wed Oct 28 01:35:56 UTC 2020

Since every single use of DIR* was converted to use g_autoptr, this
function is not currently needed. Even if someone comes up with a
usage for a non-g_autoptr DIR* in the future, they can just use
virDirClose(), since there is no longer a semantic difference between
the two (VIR_DIR_CLOSE() previously had an extra & on the pointer so
that it could be transparently passed as a DIR** to virDirClose(), but
that was removed several commits back.)

Signed-off-by: Laine Stump <laine at redhat.com>
 src/util/virfile.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/util/virfile.h b/src/util/virfile.h
index 6973fbd54a..ba31a78e58 100644
--- a/src/util/virfile.h
+++ b/src/util/virfile.h
@@ -272,7 +272,6 @@ int virDirRead(DIR *dirp, struct dirent **ent, const char *dirname)
 void virDirClose(DIR *dirp)
-#define VIR_DIR_CLOSE(dir)  virDirClose(dir)
 int virFileMakePath(const char *path) G_GNUC_WARN_UNUSED_RESULT;
 int virFileMakePathWithMode(const char *path,

More information about the libvir-list mailing list