[PATCH] security: Use org namespace for xattrs on macOS

Andrea Bolognani abologna at redhat.com
Wed Oct 28 19:16:55 UTC 2020


On Mon, 2020-10-26 at 00:25 +0300, Roman Bolshakov wrote:
> There're no guidelines on what namespace should be used but it seems
> thirdparty apps can select the one they like [1], i.e. freedekstop
> xattrs are prefixed with xdg.
> 
> qemusecuritytest passes after that.
> 
> 1. https://www.freedesktop.org/wiki/CommonExtendedAttributes/
> 
> Signed-off-by: Roman Bolshakov <r.bolshakov at yadro.com>
> ---
>  src/security/security_util.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/security/security_util.c b/src/security/security_util.c
> index 7fa5163fe4..5d50acb574 100644
> --- a/src/security/security_util.c
> +++ b/src/security/security_util.c
> @@ -56,6 +56,8 @@ VIR_LOG_INIT("security.security_util");
>  # define XATTR_NAMESPACE "trusted"
>  #elif defined(__FreeBSD__)
>  # define XATTR_NAMESPACE "system"
> +#elif defined(__APPLE__)
> +# define XATTR_NAMESPACE "org"
>  #endif

Considering that Apple uses com.apple for its own xattrs, libvirt
using org.libvirt makes sense to me.

Reviewed-by: Andrea Bolognani <abologna at redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list