[libvirt PATCH] meson: add -Wformat explicitly

Michal Privoznik mprivozn at redhat.com
Tue Sep 1 13:34:09 UTC 2020


On 9/1/20 3:30 PM, Pavel Hrdina wrote:
> If someone runs `meson setup --buildtype plain` meson ignores
> warning_level=2 that is in our meson.build file. The implication is
> that Meson will not automatically add -Wall which enables -Wformat.
> 
> This breaks building libvirt from git with the buildtype set to plain.
> 
> There is an issue reported [1] to not ignore warning_level silently
> and the change to ignore it was done by upstream commit [2].
> 
> [1] <https://github.com/mesonbuild/meson/issues/7399>
> [2] <https://github.com/mesonbuild/meson/commit/8ee1c9a07a3a35e3ed262fbc358fd86c257a966e>
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>   meson.build | 1 +
>   1 file changed, 1 insertion(+)
> 
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list