[PATCH 3/5] meson: Drop checks for some functions and header files
Michal Privoznik
mprivozn at redhat.com
Wed Sep 2 10:56:27 UTC 2020
On 9/2/20 11:56 AM, Ján Tomko wrote:
> On a Tuesday in 2020, Michal Privoznik wrote:
>> In meson.build, we check for presence of unshare() function
>> explicitly (even though there is the function usability check a
>> few hundred lines below), but never have any code depending on
>> HAVE_UNSHARE. The same applies to stdarg.h and sys/sysctl.h
>> header files - either we simply include them or guard their
>> include using different conditionals.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>> meson.build | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/meson.build b/meson.build
>> index e193166a9b..cdf33436f3 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -672,7 +672,6 @@ functions = [
>> 'stat64',
>> 'symlink',
>> 'sysctlbyname',
>> - 'unshare',
>> ]
>>
>> foreach function : functions
>> @@ -696,11 +695,9 @@ headers = [
>> 'net/if.h',
>> 'pty.h',
>> 'pwd.h',
>> - 'stdarg.h',
>
> Actually, checking for stdarg.h is necessary on macOS where
> we need to have HAVE_STDARG_H defined for readline to use the
> correct prototype for rl_message.
>
> See commit 9ea3424a178 for more context.
Facepalm. This is what I was afraid of - that a header file we use will
depend on autotools HAVE_ prefix. Let me see if I can fix this.
Michal
More information about the libvir-list
mailing list