[PATCH v2] qemu: Do not silently allow non-available timers on non-x86 systems
Michal Privoznik
mprivozn at redhat.com
Wed Sep 2 16:48:26 UTC 2020
On 8/5/20 12:22 PM, Thomas Huth wrote:
> libvirt currently silently allows <timer name="kvmclock"/> and some
> other timer tags in the guest XML definition for timers that do not
> exist on non-x86 systems. We should not silently ignore these tags
> since the users might not get what they expected otherwise.
> Note: The error is only generated if the timer is marked with
> present="yes" - otherwise we would suddenly refuse XML definitions
> that worked without problems before.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1754887
> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
> v2: Check also for timer->present == 1
>
> src/qemu/qemu_validate.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
Terribly sorry for letting this slip.
Reviewed-by: Michal Privoznik <mprivozn at redhat.com>
and pushed now.
Michal
More information about the libvir-list
mailing list