[libvirt PATCH v2] meson: add -Wall and -Wextra explicitly
Daniel P. Berrangé
berrange at redhat.com
Thu Sep 3 12:14:53 UTC 2020
On Thu, Sep 03, 2020 at 02:08:06PM +0200, Pavel Hrdina wrote:
> If someone runs `meson setup --buildtype plain` meson ignores
> warning_level=2 that is in our meson.build file. The implication is
> that Meson will not automatically add -Wall which enables -Wformat.
> This breaks building libvirt from git with the buildtype set to plain.
> There is an issue reported  to not ignore warning_level silently
> and the change to ignore it was done by upstream commit .
> This change makes Meson print warnings about using warning_level which
> as described above doesn't work for all build types.
>  <https://github.com/mesonbuild/meson/issues/7399>
>  <https://github.com/mesonbuild/meson/commit/8ee1c9a07a3a35e3ed262fbc358fd86c257a966e>
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> Chages in v2:
> - add -Wall and -Wextra explicitly regardless of the buildtype
> meson.build | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list