[PATCH] Fix linkage to libutil and libkvm on FreeBSD 11

Ján Tomko jtomko at redhat.com
Fri Sep 4 17:16:00 UTC 2020


On a Friday in 2020, Daniel P. Berrangé wrote:
>We are currently adding -lutil and -lkvm to the linker using the
>add_project_link_arguments method. On FreeBSD 11.4, this results in
>build errors because the args appear too early in the command line.
>
>We need to pass the libraries as dependencies so that they get placed
>at the same point in the linker args as other dependencies.
>
>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>---
> meson.build           | 16 +++++++---------
> src/bhyve/meson.build | 15 +++++++++++----
> src/util/meson.build  | 26 +++++++++++++++++---------
> 3 files changed, 35 insertions(+), 22 deletions(-)
>
>Using the CI patch I posted earlier to add FreeBSD 11:
>
>  https://gitlab.com/berrange/libvirt/-/pipelines/185834799
>
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

And it looks like a fun and safe change to push on a Friday afternoon.

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200904/09bedad8/attachment-0001.sig>


More information about the libvir-list mailing list