[PATCH] Do not report error when setting affinity is allowed to fail

Martin Kletzander mkletzan at redhat.com
Sun Sep 6 11:50:17 UTC 2020


On Sun, Sep 06, 2020 at 01:36:06PM +0200, Martin Kletzander wrote:
>Suggested-by: Ján Tomko <jtomko at redhat.com>
>
>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>---
> src/lxc/lxc_controller.c |  2 +-
> src/qemu/qemu_driver.c   |  7 ++++---
> src/qemu/qemu_process.c  | 10 +++++-----
> src/util/virprocess.c    | 32 +++++++++++++++++++++++---------
> src/util/virprocess.h    |  2 +-
> 5 files changed, 34 insertions(+), 19 deletions(-)
>

[...]

>diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
>index 17d083d192a5..423c60c7c85b 100644
>--- a/src/qemu/qemu_process.c
>+++ b/src/qemu/qemu_process.c

[...]

>@@ -2751,9 +2752,8 @@ qemuProcessSetupPid(virDomainObjPtr vm,
>          *  1) libvirtd does not have CAP_SYS_NICE
>          *  2) libvirtd does not run on all CPUs
>          *
>-         * However since this scenario is very improbable, we rather skip
>-         * reporting the error because it helps running libvirtd in a a scenario
>-         * where pinning is handled by someone else.
>+         * This scenario can easily occurr when libvirtd is run inside a
>+         * container with restrictive permissions and CPU pinning.

Consider the patch without this hunk.  I forgot to keep it separate, but it is
pushed already:

   https://gitlab.com/libvirt/libvirt/-/commit/fc7d53edf48a7a29397f883c0106d6b7a7c3757f
   https://www.redhat.com/archives/libvir-list/2020-September/msg00312.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200906/7cef6522/attachment-0001.sig>


More information about the libvir-list mailing list