[PATCH] qemu_process: Separate VIR_PERF_EVENT_* setting into a function

Ján Tomko jtomko at redhat.com
Mon Sep 7 20:09:15 UTC 2020


On a Monday in 2020, Michal Privoznik wrote:
>When starting a domain, qemuProcessLaunch() iterates over all
>VIR_PERF_EVENT_* values and (possibly) enables them. While there
>is nothing wrong with the code, the for loop where its done makes

*it's

>it harder to jump onto next block of code.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
>
>Is this trivial enough to be pushed as such?
>

I don't think so.

> src/qemu/qemu_process.c | 29 +++++++++++++++++++++--------
> 1 file changed, 21 insertions(+), 8 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200907/ceea852f/attachment-0001.sig>


More information about the libvir-list mailing list