[PATCH] virnuma: Report error when NUMA -> CPUs translation fails

[Martin Kletzander]

On Mon, Sep 07, 2020 at 05:11:50PM +0200, Michal Privoznik wrote:
>When starting a domain with <numatune/> set libvirt translates
>given NUMA nodes into a set of host CPUs which is then used to
>QEMU process affinity. But, if the numatune contains a
>non-existent NUMA node then the translation fails with no error
>reported. This is because virNumaNodesetToCPUset() calls
>virNumaGetNodeCPUs() and expects it to report an error on
>failure. Well, it does except for non-existent NUMA nodes. While
>this behaviour might look strange it is actually desired because
>of how we construct host capabilities. The virNumaGetNodeCPUs()
>is called from virCapabilitiesHostNUMAInitReal() where we do not
>want any error reported for non-existent NUMA nodes.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1724866
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200908/6e8989e1/attachment-0001.sig>