[PATCH] wireshark: Prefer ws_version.h over config.h

Martin Kletzander mkletzan at redhat.com
Tue Sep 8 08:20:53 UTC 2020

On Mon, Sep 07, 2020 at 08:30:08PM +0200, Michal Privoznik wrote:
>A wireshark plugin must declare what major and minor version it
>was built with as these are checked when wireshark loads plugins.
>On the top of that, we use major + minor + micro to adapt to
>changed API between releases. So far, we were getting these
>version numbers from wireshark/config.h.
>And while most distributions install wireshark/config.h file some
>don't. On distros shipping it it's hack^Wsaved during built by
>packaging system and installed later. But some distros are not
>doing that. At least not for new enough wireshark because as of
>wireshark's commit v2.9.0~1273 the ws_version.h is installed
>which contains the version macros we need and is installed by
>wireshark itself.
>But of course, some distros which have new enough wireshark
>packaged do not ship ws_version.h and stick to the hack. That is
>why we can't simply bump the minimal version and switch to the
>new header file. We need a configure check and adopt our code to
>deal with both ways. At least for the time being.
>Based on Andrea's original patch:
>Closes: https://gitlab.com/libvirt/libvirt/-/issues/74
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200908/bb7c0c38/attachment-0001.sig>

More information about the libvir-list mailing list