[PATCH] disk storage: fix allocation size for pool format dos

Michal Privoznik mprivozn at redhat.com
Wed Sep 9 14:54:28 UTC 2020


On 8/29/20 2:49 AM, Sebastian Mitterle wrote:
> The changed condition was always false because the function was always
> called with boundary values 0.
> 
> Use the free extent's start value to get its start offset from the
> cylinder boundary and determine if the needed size for allocation
> needs to be expanded too in case the offset doesn't fit within extra
> bytes for alignment.
> 
> This fixes an issue where vol-create-from will call qemu-img convert
> to create a destination volume of same capacity as the source volume
> and qemu-img will error 'Cannot grow device files' due to the partition
> being too small for the source although both destination partition and
> source volume have the same capacity.
> 
> Signed-off-by: Sebastian Mitterle <smitterl at redhat.com>
> ---
>   src/storage/storage_backend_disk.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list