[PATCH v5 1/2] conf: add 'isa' controller type

[Ján Tomko]

On a Saturday in 2020, Roman Bogorodskiy wrote:
>Introduce 'isa' controller type. In domain XML it looks this way:
>
>    ...
>    <controller type='isa' index='0'>
>      <address type='pci' domain='0x0000' bus='0x00' slot='0x01'
>               function='0x0'/>
>    </controller>
>    ...
>
>Currently, this is needed for the bhyve driver to allow choosing a
>specific PCI address for that. In bhyve, this controller is used to
>attach serial ports and a boot ROM.
>
>Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
>---
> docs/formatdomain.html.in      | 6 +++---
> docs/schemas/domaincommon.rng  | 6 ++++++
> src/conf/domain_conf.c         | 9 +++++++++
> src/conf/domain_conf.h         | 8 ++++++++
> src/qemu/qemu_command.c        | 1 +
> src/qemu/qemu_domain.c         | 1 +
> src/qemu/qemu_domain_address.c | 1 +
> src/qemu/qemu_validate.c       | 1 +
> src/vbox/vbox_common.c         | 1 +
> 9 files changed, 31 insertions(+), 3 deletions(-)
>
>diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
>index 6b67a09bb3..f70e5abab8 100644
>--- a/docs/formatdomain.html.in
>+++ b/docs/formatdomain.html.in
>@@ -4706,9 +4706,9 @@
>
>     <p>
>       Each controller has a mandatory attribute <code>type</code>,
>-      which must be one of 'ide', 'fdc', 'scsi', 'sata', 'usb',
>-      'ccid', 'virtio-serial' or 'pci', and a mandatory
>-      attribute <code>index</code> which is the decimal integer
>+      which must be one of 'ide', 'fdc', 'scsi', 'sata', 'usb', 'ccid', 'virtio-serial',
>+      'xenbus', 'pci', or 'isa' (<span class="since">since 6.7.0</span>),

this will be: isa (:since:`since 6.8.0`)
in the .rst version

>+      and a mandatory attribute <code>index</code> which is the decimal integer
>       describing in which order the bus controller is encountered (for
>       use in <code>controller</code> attributes of
>       <code><address></code> elements).

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200910/12559dc5/attachment-0001.sig>