[PATCH] qemu: fix concurrency crash bug in force snapshot revert

Michal Privoznik mprivozn at redhat.com
Wed Sep 16 08:08:03 UTC 2020

On 9/14/20 2:23 PM, Nikolay Shirokovskiy wrote:
> This patch is just revert of [1]. Actually we should NOT pass
> QEMU_ASYNC_JOB_NONE as that patch suggests while we are in async job in order
> to acquire nested jobs correctly. The patch tries to fix issues introduced by
> another patch [2] where jobs are mistakenly cleared out in qemuProcessStop.
> Later patch [3] fixed the issue introduced by patch [2]. Now we need to revert
> [1] as well as we now still have same concurrency crash issues as [3] described
> but for the force revert.
> [1] 0c4408c83: qemu: Don't use asyncJob after stop during snapshot revert
> [2] 888aa4b6b: qemuDomainObjPrivateDataClear: Don't leak @migParams
> [3] d75f865fb: qemu: fix concurrency crash bug in snapshot revert
> Signed-off-by: Nikolay Shirokovskiy <nshirokovskiy at virtuozzo.com>
> ---
>   src/qemu/qemu_snapshot.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>


More information about the libvir-list mailing list