[PATCH] tests: avoid close of bad file handle in commandtest

Eric Blake eblake at redhat.com
Mon Sep 21 18:38:21 UTC 2020


On 9/21/20 12:38 PM, Daniel P. Berrangé wrote:
> Closed file handles need to be initialized to -1, not 0. This caused a
> inappropriate double close of stdin, which is not desirable, although
> it had no ill effects.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>   tests/commandtest.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <eblake at redhat.com>

> 
> diff --git a/tests/commandtest.c b/tests/commandtest.c
> index 42225a8ef2..cbbcda4e5f 100644
> --- a/tests/commandtest.c
> +++ b/tests/commandtest.c
> @@ -1091,8 +1091,8 @@ static int test27(const void *unused G_GNUC_UNUSED)
>           printf("Could not set send buffers\n");
>           goto cleanup;
>       }
> -    pipe1[1] = 0;
> -    pipe2[1] = 0;
> +    pipe1[1] = -1;
> +    pipe2[1] = -1;
>       buffer1 = NULL;
>       buffer2 = NULL;
>   
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list