[PATCH v6 3/3] bhyve: soften requirements for slot 1
Roman Bogorodskiy
bogorodskiy at gmail.com
Tue Sep 22 11:56:46 UTC 2020
Daniel P. Berrangé wrote:
> On Sun, Sep 20, 2020 at 07:21:15PM +0400, Roman Bogorodskiy wrote:
> > Currently, slot 1 is only allowed to be used by the LPC device.
> > Relax this requirement and allow to use slot 1 if it was explicitly
> > specified by the user for any other device type. In this case the LPC
> > device will have the next available address.
> >
> > If slot 1 was not used by the user, it'll be reserved for the LPC
> > device, even if it is not configured to make address assignment
> > consistent in case the LPC device becomes necessary (e.g. the user
> > adds a console or a video device which require LPC).
> >
> > Signed-off-by: Roman Bogorodskiy <bogorodskiy at gmail.com>
> > ---
> > po/POTFILES.in | 1 -
> > src/bhyve/bhyve_device.c | 50 +++++++++----------
> > ...argv-addr-non-isa-controller-on-slot-1.xml | 1 +
> > tests/bhyvexml2argvtest.c | 2 +-
> > 4 files changed, 25 insertions(+), 29 deletions(-)
>
> We're missing the bhyvexml2argv-addr-non-isa-controller-on-slot-1.args
> file from the commit, so this breaks CI. I presume you forgot to commit
> it from your local checkout.
Indeed, I'll add that shortly. Sorry for the breakage.
>
> Regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
>
Roman Bogorodskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200922/2bb9b277/attachment-0001.sig>
More information about the libvir-list
mailing list