[libvirt PATCH] virgdbus: add DBus reply format check

Ján Tomko jtomko at redhat.com
Wed Sep 23 10:44:10 UTC 2020


On a Monday in 2020, Pavel Hrdina wrote:
>We used to check the format of reply data with libdbus so we should do
>the same with GLib DBus as well.
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
>
>At first I thought that this is not necessary as it is unlikely to
>happen but after Jano found the bug with firewalld getZones function
>and asked about checking return values I figured out that it will be
>better to check it because if the returned message would have different
>format it would be silently ignored.
>
> src/rpc/virnetdaemon.c  | 1 +
> src/util/virfirewalld.c | 5 +++++
> src/util/virgdbus.c     | 8 ++++++--
> src/util/virgdbus.h     | 2 ++
> src/util/virpolkit.c    | 1 +
> src/util/virsystemd.c   | 7 +++++++
> 6 files changed, 22 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200923/7f26f9ca/attachment-0001.sig>


More information about the libvir-list mailing list