[PATCH 6/6] qemuSnapshotDiskPrepare: rename to qemuSnapshotDiskPrepareActiveExternal

Peter Krempa pkrempa at redhat.com
Thu Sep 24 07:37:51 UTC 2020


Make it obvious that the snapshot is prepared for the active external
snapshot case.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_snapshot.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
index 6fe925763e..5fe9771205 100644
--- a/src/qemu/qemu_snapshot.c
+++ b/src/qemu/qemu_snapshot.c
@@ -1087,18 +1087,18 @@ qemuSnapshotDiskPrepareOne(virDomainObjPtr vm,


 /**
- * qemuSnapshotDiskPrepare:
+ * qemuSnapshotDiskPrepareActiveExternal:
  *
  * Collects and prepares a list of structures that hold information about disks
  * that are selected for the snapshot.
  */
 static qemuSnapshotDiskContextPtr
-qemuSnapshotDiskPrepare(virDomainObjPtr vm,
-                        virDomainMomentObjPtr snap,
-                        virQEMUDriverConfigPtr cfg,
-                        bool reuse,
-                        virHashTablePtr blockNamedNodeData,
-                        qemuDomainAsyncJob asyncJob)
+qemuSnapshotDiskPrepareActiveExternal(virDomainObjPtr vm,
+                                      virDomainMomentObjPtr snap,
+                                      virQEMUDriverConfigPtr cfg,
+                                      bool reuse,
+                                      virHashTablePtr blockNamedNodeData,
+                                      qemuDomainAsyncJob asyncJob)
 {
     g_autoptr(qemuSnapshotDiskContext) snapctxt = NULL;
     size_t i;
@@ -1242,8 +1242,8 @@ qemuSnapshotCreateActiveExternalDisks(virDomainObjPtr vm,

     /* prepare a list of objects to use in the vm definition so that we don't
      * have to roll back later */
-    if (!(snapctxt = qemuSnapshotDiskPrepare(vm, snap, cfg, reuse,
-                                             blockNamedNodeData, asyncJob)))
+    if (!(snapctxt = qemuSnapshotDiskPrepareActiveExternal(vm, snap, cfg, reuse,
+                                                           blockNamedNodeData, asyncJob)))
         return -1;

     if (qemuSnapshotDiskCreate(snapctxt, cfg) < 0)
-- 
2.26.2




More information about the libvir-list mailing list