[PATCH 2/2] qemu: Use .hostdevice attribute for usb-host
jtomko at redhat.com
Tue Sep 29 15:59:32 UTC 2020
On a Monday in 2020, Michal Privoznik wrote:
>This originally started as bug 1595525 in which namespaces and
>libusb used in QEMU were not playing nicely with each other. The
>problem was that libusb built a cache of USB devices it saw
>(which was a very limited set because of the namespace) and then
>expected to receive udev events to keep the cache in sync. But
>those udev events didn't come because on hotplug when we mknod()
>devices in the namespace no udev event is generated. And what is
>worse - libusb failed to open a device that wasn't in the cache.
>Without going further into what the problem was, libusb added a
>new API for opening USB devices that avoids using cache which
>QEMU incorporated and exposes under "hostdevice" attribute.
>What is even nicer is that QEMU uses qemu_open() for path
>provided in the attribute and thus FD passing could be used.
>Except qemu_open() expects so called FD sets instead of `getfd'
>and these are not implemented in Libvirt, yet.
Are you looking for `qemuVirCommandGetFDSet`?
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> src/qemu/qemu_command.c | 21 +++++++++++++--------
> 1 file changed, 13 insertions(+), 8 deletions(-)
Reviewed-by: Ján Tomko <jtomko at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 488 bytes
Desc: not available
More information about the libvir-list