[PATCH 4/9] build: remove check for MACVLAN_MODE_PASSTHRU

Laine Stump laine at redhat.com
Wed Sep 30 23:14:39 UTC 2020


macvlan support was added to the Linux kernel in 2.6.33, but
MACVLAN_MODE_PASSTHRU wasn't added until 2.6.38, so a workaround had
been put in place to define that constant on those few systems where
it was missing. It's useful like was probably 6 months at most, but
it's been there for over 10 years.

Signed-off-by: Laine Stump <laine at redhat.com>
---
 meson.build                 | 4 ----
 src/util/virnetdevmacvlan.c | 5 -----
 2 files changed, 9 deletions(-)

diff --git a/meson.build b/meson.build
index 073ea6d49e..5e0af76bbc 100644
--- a/meson.build
+++ b/meson.build
@@ -1172,10 +1172,6 @@ if not get_option('macvtap').disabled()
 endif
 if use_macvtap
   conf.set('WITH_MACVTAP', 1)
-
-  if cc.has_header_symbol('linux/if_link.h', 'MACVLAN_MODE_PASSTHRU')
-    conf.set('WITH_DECL_MACVLAN_MODE_PASSTHRU', 1)
-  endif
 endif
 
 netcf_version = '0.1.8'
diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c
index 143e1ab98c..889cbb2293 100644
--- a/src/util/virnetdevmacvlan.c
+++ b/src/util/virnetdevmacvlan.c
@@ -47,11 +47,6 @@ VIR_ENUM_IMPL(virNetDevMacVLanMode,
 # include <linux/if_tun.h>
 # include <math.h>
 
-/* Older kernels lacked this enum value.  */
-# if !WITH_DECL_MACVLAN_MODE_PASSTHRU
-#  define MACVLAN_MODE_PASSTHRU 8
-# endif
-
 # include "viralloc.h"
 # include "virlog.h"
 # include "viruuid.h"
-- 
2.26.2




More information about the libvir-list mailing list