[PATCH 4/5] nss: Drop needless include of rpc/types.h

Michal Privoznik mprivozn at redhat.com
Tue Sep 1 14:00:13 UTC 2020


In packet-libvirt.c in wireshark dissector we include rpc/types.h
but guard the include with a condition (that is supposed to be
true if we detected during configure phase that the host system
has the header file). Thing is, it looks like we were never doing
the configure check and thus the file was never included and yet,
the NSS plugin works. Drop the include then.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tools/wireshark/src/packet-libvirt.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/tools/wireshark/src/packet-libvirt.c b/tools/wireshark/src/packet-libvirt.c
index 89dd18080e..9f3c7f650d 100644
--- a/tools/wireshark/src/packet-libvirt.c
+++ b/tools/wireshark/src/packet-libvirt.c
@@ -22,9 +22,6 @@
 #include <wireshark/epan/proto.h>
 #include <wireshark/epan/packet.h>
 #include <wireshark/epan/dissectors/packet-tcp.h>
-#ifdef HAVE_RPC_TYPES_H
-# include <rpc/types.h>
-#endif
 #include <rpc/xdr.h>
 #include "packet-libvirt.h"
 #include "internal.h"
-- 
2.26.2




More information about the libvir-list mailing list