[libvirt PATCH] wireshark: Don't include config.h

Andrea Bolognani abologna at redhat.com
Mon Sep 7 14:56:53 UTC 2020


On Fri, 2020-09-04 at 17:37 +0200, Michal Prívozník wrote:
> On 9/4/20 5:12 PM, Andrea Bolognani wrote:
> > I don't think it's done on purpose: it's probably just a bug in the
> > Debian packaging that got propagated to Ubuntu.
> > 
> > Even assuming that's the case, it will take some time for it to be
> > addressed in sid, and the first Ubuntu LTS that will carry the
> > resulting fix is almost two years out... So I think we have to just
> > support both ws_version.h and config.h for a while.
> 
> Ah, so on one hand we have progressive distro that doesn't install 
> internal header files, on the other we have LTS distros where changing 
> something may take years to take effect. In that case our only option is 
> to implement both ways. Or motivate LTS distros to implement the change 
> sooner ;-)
> 
> Since you wrote the original patch, do you want to write this one too? 
> Or do you want me to do it?

I would like to see this addressed, but since there is additional
work involved it's realistically going to be a while before I can get
back to it. So, if you have any interest in writing a better patch
yourself and time to actually do it, please by all means go ahead!

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list