[libvirt] [PATCH 05/12] virsh: net-port-create: log errors for non-existent xml file

Ján Tomko jtomko at redhat.com
Sat Sep 12 10:34:24 UTC 2020


On a Friday in 2020, Lin Ma wrote:
>Signed-off-by: Lin Ma <lma at suse.de>
>---
> tools/virsh-network.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/virsh-network.c b/tools/virsh-network.c
>index f0f5358625..ce67e3f19b 100644
>--- a/tools/virsh-network.c
>+++ b/tools/virsh-network.c
>@@ -1522,6 +1522,7 @@ cmdNetworkPortCreate(vshControl *ctl, const vshCmd *cmd)
>
>     ret = true;
>  cleanup:
>+    vshReportError(ctl);

vshReportError is already called in vshCommandRun,
all that's needed here is a vshSaveLibvirtError call, before
the error gets reset by virNetwork*Free APIs

Jano

>     VIR_FREE(buffer);
>     if (port)
>         virNetworkPortFree(port);
>-- 
>2.26.0
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200912/7d1a6a2f/attachment-0001.sig>


More information about the libvir-list mailing list