[PATCH 4/5] node_device: detect DASD devices

[Boris Fiuczynski]

On 9/14/20 7:17 AM, Erik Skultety wrote:
> ...
>>>>        }
>>>> +    /* dasd disk */
>>>> +    if (STRPREFIX(def->caps->data.storage.block, "/dev/dasd")) {
>>>> +        def->caps->data.storage.drive_type = g_strdup("dasd");
>>>> +        VIR_DEBUG("Found storage type '%s' for device "
>>>> +                  "with sysfs path '%s'",
>>>> +                  def->caps->data.storage.drive_type,
>>>> +                  def->sysfs_path);
>>>
>>> I understand why we would need it for /dev/vdX, but can udev not know the
>>> drive_type from kernel? IOW Do we really need ^this hunk?
>>>
>>
>> For DASDs there are currently no identifies in udev besides ID_PATH.
>> ID_TYPE=disk does not exist. That's why the DASDs fall through the
>> udevProcessStorage detection logic. Without this hunk the dasd devices are
>> being detected as storage devices but than end up as "Unsupported storage
>> type".
>> The short answer is yes. :-)
> 
> Okay, can you put a concise version of ^this in a commentary then?
> 
> Erik
> 
Done, I am going to send a v2 later.

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294