[PATCH v1 4/4] NEWS.rst: document the pSeries NVDIMM auto-alignment revival
Daniel Henrique Barboza
danielhb413 at gmail.com
Thu Sep 17 20:35:53 UTC 2020
On 9/17/20 1:02 PM, Andrea Bolognani wrote:
> On Mon, 2020-09-14 at 23:42 -0300, Daniel Henrique Barboza wrote:
>> + * Re-introduce NVDIMM auto-alignment for pSeries Guests
>> +
>> + This feature was removed in libvirt v6.7.0 due to its shortcomings, namely
>> + the lack of consistency between domain XML and actual NVDIMM size the guest
>> + is using, but it came at a too high of a cost - we broke existing guests
>> + that were running in libvirt v.6.6.0 and now had to adjust the size by
>> + hand. The auto-alignment was re-introduced back, allowing existing guests
>> + to keep running as usual. But now, instead of auto-aligning in a transparent
>> + manner, it is also changing the domain XML. This brings a good balance
>> + between consistency of domain XML and guest information, and also relieves
>> + the user of knowing the alignment internals of pSeries NVDIMMs.
>
> I feel like this is needlessly verbose. How about something like
>
> * Re-introduce NVDIMM auto-alignment for pSeries Guests
>
> The auto-alignment logic was removed in v6.7.0 in favor of
> requiring the size provided by the user to be already aligned;
> however, this had the unintended consequence of breaking some
> existing guests. v6.8.0 restores the previous behavior, and as an
> improvement upon it also reflects the auto-aligned value in the
> domain XML.
>
> instead?
LGTM. I'll change it in v2.
Thanks,
DHB
>
More information about the libvir-list
mailing list