[libvirt PATCH 4/5] virsh: do not return bool in virshNetworkPortUUIDCompleter

Ján Tomko jtomko at redhat.com
Tue Sep 22 21:32:32 UTC 2020


portability: Returning an integer in a function with pointer
return type is not portable. [CastIntegerToAddressAtReturn]

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 tools/virsh-completer-network.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/virsh-completer-network.c b/tools/virsh-completer-network.c
index a63d657477..73f7115ab2 100644
--- a/tools/virsh-completer-network.c
+++ b/tools/virsh-completer-network.c
@@ -103,7 +103,7 @@ virshNetworkPortUUIDCompleter(vshControl *ctl,
         return NULL;
 
     if (!(net = virshCommandOptNetwork(ctl, cmd, NULL)))
-        return false;
+        return NULL;
 
     if ((nports = virNetworkListAllPorts(net, &ports, flags)) < 0)
         return NULL;
-- 
2.26.2




More information about the libvir-list mailing list