[PATCH 39/39] tests: string: Remove pointless test for virStringListFreeCount
Peter Krempa
pkrempa at redhat.com
Thu Apr 1 13:52:38 UTC 2021
It's way more useful to run valgrind against the rest of the code than
this test to see whether virStringListFreeCount works. Remove the test.
Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
tests/virstringtest.c | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/tests/virstringtest.c b/tests/virstringtest.c
index 82e8e2106f..83b883524d 100644
--- a/tests/virstringtest.c
+++ b/tests/virstringtest.c
@@ -392,24 +392,6 @@ testStringToDouble(const void *opaque)
return ret;
}
-/* The point of this test is to check whether all members of the array are
- * freed. The test has to be checked using valgrind. */
-static int
-testVirStringListFreeCount(const void *opaque G_GNUC_UNUSED)
-{
- char **list;
-
- list = g_new0(char *, 4);
-
- list[0] = g_strdup("test1");
- list[2] = g_strdup("test2");
- list[3] = g_strdup("test3");
-
- virStringListFreeCount(list, 4);
-
- return 0;
-}
-
struct testStripData {
const char *string;
@@ -718,11 +700,6 @@ mymain(void)
NULL,
3.141592653589793238462643383279502884197169399375105);
- /* test virStringListFreeCount */
- if (virTestRun("virStringListFreeCount", testVirStringListFreeCount,
- NULL) < 0)
- ret = -1;
-
#define TEST_STRIP_IPV6_BRACKETS(str, res) \
do { \
struct testStripData stripData = { \
--
2.29.2
More information about the libvir-list
mailing list