[libvirt PATCH] vsh: fix memory leak in vshCommandParse

Ján Tomko jtomko at redhat.com
Wed Apr 7 15:29:50 UTC 2021


One of the error branches used a plain free where vshCommandFree
was required.

https://bugzilla.redhat.com/show_bug.cgi?id=1943415

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 tools/vsh.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/vsh.c b/tools/vsh.c
index 552ed29ab9..d9c0a9b80d 100644
--- a/tools/vsh.c
+++ b/tools/vsh.c
@@ -1530,7 +1530,7 @@ vshCommandParse(vshControl *ctl, vshCommandParser *parser, vshCmd **partial)
 
             if (!partial &&
                 vshCommandCheckOpts(ctl, c, opts_required, opts_seen) < 0) {
-                VIR_FREE(c);
+                vshCommandFree(c);
                 goto syntaxError;
             }
 
-- 
2.29.2




More information about the libvir-list mailing list