[PATCH 13/39] virLogParseOutputs: Refactor string list handling

[Ján Tomko]

On a Thursday in 2021, Peter Krempa wrote:
>Rewrite the code to remove the need to calculate the string list count.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/util/virlog.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/src/util/virlog.c b/src/util/virlog.c
>index 004792db01..56059f62f1 100644
>--- a/src/util/virlog.c
>+++ b/src/util/virlog.c
>@@ -1612,22 +1612,22 @@ virLogParseOutputs(const char *src, virLogOutputPtr **outputs)
> {
>     int at = -1;
>     size_t noutputs = 0;
>-    size_t i, count;
>     g_auto(GStrv) strings = NULL;
>+    GStrv next;
>     virLogOutputPtr output = NULL;
>     virLogOutputPtr *list = NULL;
>
>     VIR_DEBUG("outputs=%s", src);
>
>-    if (!(strings = virStringSplitCount(src, " ", 0, &count)))
>+    if (!(strings = g_strsplit(src, " ", 0)))
>         return -1;
>
>-    for (i = 0; i < count; i++) {
>+    for (next = strings; *next; next++) {
>         /* virStringSplit may return empty strings */

This comment is now outdated.

>-        if (STREQ(strings[i], ""))
>+        if (STREQ(*next, ""))
>             continue;
>
>-        if (!(output = virLogParseOutput(strings[i])))
>+        if (!(output = virLogParseOutput(*next)))
>             return -1;
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210407/6d9d891e/attachment-0001.sig>