[libvirt PATCH v4 2/8] virxml: Add virXMLPropTristateSwitch

[Tim Wiederhake]

Convenience function to return the value of an on / off XML attribute.

Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
---
 src/libvirt_private.syms |  1 +
 src/util/virxml.c        | 49 ++++++++++++++++++++++++++++++++++++++++
 src/util/virxml.h        |  4 ++++
 3 files changed, 54 insertions(+)

diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
index 1aac0de1ae..776387e6b3 100644
--- a/src/libvirt_private.syms
+++ b/src/libvirt_private.syms
@@ -3547,6 +3547,7 @@ virXMLPickShellSafeComment;
 virXMLPropString;
 virXMLPropStringLimit;
 virXMLPropTristateBool;
+virXMLPropTristateSwitch;
 virXMLSaveFile;
 virXMLValidateAgainstSchema;
 virXMLValidatorFree;
diff --git a/src/util/virxml.c b/src/util/virxml.c
index 0b822d7c4d..f62c5c39c4 100644
--- a/src/util/virxml.c
+++ b/src/util/virxml.c
@@ -607,6 +607,55 @@ virXMLPropTristateBool(xmlNodePtr node, const char* name,
 }
 
 
+/**
+ * virXMLPropTristateSwitch:
+ * @node: XML dom node pointer
+ * @name: Name of the property (attribute) to get
+ * @flags: Bitwise or of virXMLPropFlags
+ * @result: The returned value
+ *
+ * Convenience function to return value of an on / off attribute.
+ *
+ * Returns 1 in case of success in which case @result is set,
+ *         or 0 if the attribute is not present,
+ *         or -1 and reports an error on failure.
+ */
+int
+virXMLPropTristateSwitch(xmlNodePtr node, const char* name,
+                         virXMLPropFlags flags, virTristateSwitch *result)
+{
+    g_autofree char *tmp = NULL;
+    int val;
+
+    if (!node || !name || !result) {
+        virReportError(VIR_ERR_INTERNAL_ERROR,
+                       _("Invalid argument to %s"),
+                       __FUNCTION__);
+        return -1;
+    }
+
+    if (!(tmp = virXMLPropString(node, name))) {
+        if ((flags & VIR_XML_PROP_REQUIRED) != VIR_XML_PROP_REQUIRED)
+            return 0;
+
+        virReportError(VIR_ERR_XML_ERROR,
+                       _("Missing required attribute '%s' in element '%s'"),
+                       name, node->name);
+        return -1;
+    }
+
+    if ((val = virTristateSwitchTypeFromString(tmp)) <= 0) {
+        virReportError(VIR_ERR_XML_ERROR,
+                       _("Invalid value for attribute '%s' in element '%s': '%s'. Expected 'on' or 'off'"),
+                       name, node->name, tmp);
+        return -1;
+    }
+
+    *result = val;
+    return 1;
+}
+
+
 /**
  * virXPathBoolean:
  * @xpath: the XPath string to evaluate
diff --git a/src/util/virxml.h b/src/util/virxml.h
index 53de416a7f..a5ecfbb01a 100644
--- a/src/util/virxml.h
+++ b/src/util/virxml.h
@@ -87,6 +87,10 @@ int       virXMLPropTristateBool(xmlNodePtr node,
                                  const char *name,
                                  virXMLPropFlags flags,
                                  virTristateBool *result);
+int     virXMLPropTristateSwitch(xmlNodePtr node,
+                                 const char *name,
+                                 virXMLPropFlags flags,
+                                 virTristateSwitch *result);
 
 /* Internal function; prefer the macros below.  */
 xmlDocPtr      virXMLParseHelper(int domcode,
-- 
2.26.2