[libvirt PATCH 0/6] meson: sanitize our compiler flags handling

Pavel Hrdina phrdina at redhat.com
Thu Apr 8 11:39:05 UTC 2021


On Thu, Apr 08, 2021 at 11:58:17AM +0100, Daniel P. Berrangé wrote:
> Currently our compiler flags handling has a number of flaws and
> misleading characteristics
> 
>  - It triggers warnings from Meson due to our use of -Wall/-Wextra
>    that prevents us using --fatal-meson-warnings
> 
>  - We enable flags, only to turn them back off again eg
>       "-Wcast-function-type ...  -Wno-cast-function-type"
> 
>  - We check for certain flags twice
> 
>  - We don't check compiler support for some flags
> 
> Daniel P. Berrangé (6):
>   meson: get rid of list of unused warning flags
>   meson: actually check for -Wframe-larger-than
>   meson: merge all cc_flags arrays into one
>   meson: avoid checking compiler flags twice
>   meson: honour meson warning_level option
>   meson: don't probe for -Werror if -Dwerror is enabled

With the comments addressed:

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210408/2afad241/attachment-0001.sig>


More information about the libvir-list mailing list