[libvirt PATCH] meson: remove obsolete comment about stack frame size

Pavel Hrdina phrdina at redhat.com
Thu Apr 8 13:16:11 UTC 2021


On Thu, Apr 08, 2021 at 02:00:16PM +0100, Daniel P. Berrangé wrote:
> The virStrerror function no longer exists in libvirt so is not a
> constraint. At the current stack limit of 4k, and default Linux
> stack size of 8 MB, we have a recursion limit of 2048 in the
> absolute worst case, and much higher in common case. Even with
> smaller stack sizes, we're going to be fine as we don't deeply
> recurse in code.
> 
> Thus it is not worth spending effort to optimize below our current
> 4k worst case limit. Removing the comment will stop encouraging
> people to spend time on this in future.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  meson.build | 3 ---
>  1 file changed, 3 deletions(-)

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210408/804c9b46/attachment-0001.sig>


More information about the libvir-list mailing list