[RFC PATCH 31/43] qemu: capabilities: Move rest of always present caps to virQEMUCapsInitQMPArch

Pavel Hrdina phrdina at redhat.com
Mon Apr 12 12:32:48 UTC 2021


On Fri, Apr 09, 2021 at 04:57:07PM +0200, Peter Krempa wrote:
> These conveniently don't have any test fallout.
> 
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>  src/qemu/qemu_capabilities.c | 16 +++++++---------
>  1 file changed, 7 insertions(+), 9 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index 36836cad3d..af0bb398e4 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -5049,6 +5049,13 @@ virQEMUCapsInitQMPBasicArch(virQEMUCapsPtr qemuCaps)
>  {
>      /* Following caps were asserted by a version check for pre 2.11 qemus */
>      virQEMUCapsSet(qemuCaps, QEMU_CAPS_DEVICE_VIDEO_PRIMARY);
> +    virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_VMPORT_OPT);
> +    virQEMUCapsSet(qemuCaps, QEMU_CAPS_VHOSTUSER_MULTIQUEUE);
> +    virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_SMM_OPT);
> +    virQEMUCapsSet(qemuCaps, QEMU_CAPS_SDL_GL);
> +    virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_KERNEL_IRQCHIP_SPLIT);
> +    virQEMUCapsSet(qemuCaps, QEMU_CAPS_EGL_HEADLESS);
> +    virQEMUCapsSet(qemuCaps, QEMU_CAPS_NUMA_DIST);

I guess eventually we should retire all of these capabilities. This
patch series does that only for QEMU_CAPS_DEVICE_VIDEO_PRIMARY.

That can be done as a followup series.

Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210412/3f339df7/attachment-0001.sig>


More information about the libvir-list mailing list