[RFC PATCH 00/43] qemu: Remove support for qemu-1.5 - qemu-2.10 and clean up capabilities

[Pavel Hrdina]

On Fri, Apr 09, 2021 at 04:56:36PM +0200, Peter Krempa wrote:
> May 7, 2021 is the 2nd anniversary of release of rhel-8, which means we
> no longer have to support qemu-1.5.
> 
> Remove the capabilities and test data for the versions we no longer care
> about and clean up some capabilities related stuff:
> 
>  - remove code for QEMU_CAPS_DEVICE_VIDEO_PRIMARY
>  - remove checking for QEMU_CAPS_QUERY_QMP_SCHEMA since all versions now
>  support it
> 
> This is also a good opportunity to clean up few things regarding the
> capabilties test data, namely call 'query-qmp-schema' before
> 'query-commands' to prepare to retire query-commands.
> 
> This series is heavily truncated since there were massive (27MiB)
> patches resulting from some of the mechanical (and generated) changes
> and also depends on my previous command line wrapping cleanup.
> Fetch the full version at:
> 
>   git fetch https://gitlab.com/pipo.sk/libvirt.git qemu-deprec-2
> 
> The cleanups in patches 41, 42, and the massive move of commands in
> patch 43 was done using a tool based on pieces of our code which I've
> uploaded to:
> 
> https://gitlab.com/pipo.sk/libvirt/-/commits/qemu-capabilities-tool
> 
> The tool may come in handy for other things too in the future as it
> allows programatic modification of the capability replies files.
> 
> Peter Krempa (43):
>   docs/platforms: Drop separate link to qemu-kvm on repology.org
>   qemuxml2xmltest: testInfoSetPaths: Remove return value
>   qemuxml2(argv|xml)test: Don't exit early when testQemuInfoSetArgs
>     fails
>   qemu: Formally deprecate support for qemu < 2.11
>   NEWS: Mention that minimum supported qemu version was bumped to 2.11
>   qemuxml2argvtest: Remove versioned tests for qemu < 2.11
>   [fixup] qemuxml2argvdata: Remove unused output files
>   qemuxml2xmltest: Remove versioned tests for qemu < 2.11
>   [fixup] qemuxml2xmldata: Remove unused output files
>   qemucapabilitiesdata: Drop capability test data for qemu < 2.11
>   virQEMUCapsHasPCIMultiBus: Remove logic for PPC multibus support check
>   qemuAssignDeviceControllerAlias: Remove unused 'qemuCaps' argument
>   qemuBuildDeviceAddressStr: Remove unused 'qemuCaps'
>   virQEMUCapsInitProcessCaps: Remove obsolete version checks
>   virQEMUCapsInitQMPVersionCaps: Remove unneeded version checks
>   virQEMUCapsInitQMPBasicArch: Use switch for arch-based decisions
>   qemuxml2argvtest: Rewrite parsing of XMLs to provide earlier parsing
>   qemuxml2argvtest: Parse 'arch' from XML early
>   qemuxml2xmltest: Always include basic set of capabilities
>   qemu: capabilities: Move setting of QEMU_CAPS_CPU_AARCH64_OFF to
>     virQEMUCapsInitQMPBasicArch
>   qemuxml2argvtest: Remove negative test case
>     'pseries-features-htp-resize'
>   qemu: capabilities: Move setting of PPC specific flags to
>     virQEMUCapsInitQMPBasicArch
>   qemuxml2argvtest: Remove negative test for gic v3/host
>   qemu: capabilities: Move setting of QEMU_CAPS_MACH_VIRT_GIC_VERSION to
>     virQEMUCapsInitQMPBasicArch
>   qemuxml2argvtest: Remove negative test case for 'net-vhostuser-multiq'
>   qemuxml2argvtest: Remove tests for absence of
>     QEMU_CAPS_DEVICE_VIDEO_PRIMARY
>   qemu: capabilities: Move setting QEMU_CAPS_DEVICE_VIDEO_PRIMARY to
>     virQEMUCapsInitQMPBasicArch
>   [fixup] Fix test fallout in tests/qemuxml2argvdata
>   [fixup] Fix test fallout in tests/qemuxml2xmloutdata
>   qemuxml2(argv|xml)test: Retire QEMU_CAPS_DEVICE_VIDEO_PRIMARY from
>     tests
>   qemu: capabilities: Move rest of always present caps to
>     virQEMUCapsInitQMPArch
>   qemuhotplugtest: Add also always-present capabilities
>   qemu: command: Remove legacy '-vga' commandline formatter
>   qemu_domain_address: Drop compatibility with pre-device vga
>     specification for i440fx
>   qemu_domain_address: Drop compatibility with pre-device vga
>     specification for q35
>   qemuDomainValidateDevicePCISlotsChipsets: Remove unused @qemuCaps
>   qemu: capabilities: Retire QEMU_CAPS_DEVICE_VIDEO_PRIMARY
>   qemu: capabilities: Always assume QEMU_CAPS_QUERY_QMP_SCHEMA
>   qemu: monitor: Remove qemuMonitorGetEvents
>   qemu: monitor: Remove qemuMonitorSupportsActiveCommit
>   tests: qemucapabilitiesdata: Fix formatting of manually added hunk
>   tests: qemucapabilitiesdata: Fix wrong command identifier in
>     caps_4.0.0.riscv64.replies
>   qemu: capabilities: Probe QMP schema before probing commands

Some of the patches can be pushed now as they are not removing support
for any older QEMUs.

The QEMU deprecation patches looks good as well. With all the fixup
squashed to the respective patches:

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210412/23f64527/attachment-0001.sig>