[libvirt PATCH] qemu_conf: properly set 'deprecation_behavior' default value

[Peter Krempa]

On Tue, Apr 13, 2021 at 13:03:44 +0200, Michal Privoznik wrote:
> On 4/13/21 12:53 PM, Peter Krempa wrote:
> > On Tue, Apr 13, 2021 at 11:10:18 +0200, Pavel Hrdina wrote:
> > > The comment for that option states that the default value is 'none' but
> > > it was not set by the code.
> > > 
> > > Fixes: 700450449377be4bf923e91d00f8fe8cf0975f66
> > > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > > ---
> > 
> > Could you please elaborate what the problem of not setting it is?
> > 
> > 'none' the same as NULL should result in doing nothing.
> > 
> 
> Is it? In qemuBuildCompatDeprecatedCommandLine() a string is initialized to
> cfg->deprecationBehavior and then passed to TypeFromString() which fails and
> thus VIR_WARN() is printed. I believe that's where crash can occur.

Ah, right. That's the stuff that should be in the commit message then.