[PATCH 3/6] nodedev: Signal initCond with driver locked

Erik Skultety eskultet at redhat.com
Tue Apr 13 14:14:26 UTC 2021


On Tue, Apr 13, 2021 at 12:01:54PM +0200, Michal Privoznik wrote:
> This is more academic dispute than a real bug, but this is taken
> from pthread_cond_broadcast(3p) man:
> 
>   The pthread_cond_broadcast() or pthread_cond_signal() functions
>   may be called by a thread whether or not it currently owns the
>   mutex that threads calling pthread_cond_wait() or
>   pthread_cond_timedwait() have associated with the condition
>   variable during their waits; however, if predictable scheduling
>   behavior is required, then that mutex shall be locked by the
>   thread calling pthread_cond_broadcast() or
>   pthread_cond_signal().
> 
> Therefore, broadcast the initCond while the nodedev driver is
> still locked.

It is consistent with what we do elsewhere.

Reviewed-by: Erik Skultety <eskultet at redhat.com>




More information about the libvir-list mailing list