[RFC PATCH 3/7] qemuMigrationSrcNBDStorageCopy: Return error code on error

Peter Krempa pkrempa at redhat.com
Tue Apr 13 15:38:23 UTC 2021


In case the 'nbdURI' schema is not known the code would report an error
but wouldn't return failure.

Fixes: 49186372dbe
Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_migration.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index df88f954ed..1c3e599128 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1154,6 +1154,7 @@ qemuMigrationSrcNBDStorageCopy(virQEMUDriver *driver,
             virReportError(VIR_ERR_INVALID_ARG,
                            _("Unsupported scheme in disks URI: %s"),
                            uri->scheme);
+            return -1;
         }
     }

-- 
2.30.2




More information about the libvir-list mailing list