[libvirt PATCH v2 02/12] nodedev: avoid use of VIR_ERR_NO_* errors internally

[Laine Stump]

On 4/13/21 4:39 PM, Jonathon Jongsma wrote:
> These errors are demoted to debug statements[1] since they're only
> intended to be used as return values for public APIs.  This makes it
> difficult to debug the problem when something goes wrong since no error
> message is logged. Switch instead to VIR_ERR_INTERNAL_ERROR so that the
> error is logged as expected.
> 
> [1] See the implementation of daemonErrorLogFilter() for details:
> https://gitlab.com/libvirt/libvirt/-/blob/e2f82a3704f680fbb37a733476d870c19232c23e/src/remote/remote_daemon.c#L89

Huh. TIL.

> 
> Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>

Reviewed-by: Laine Stump <laine at redhat.com>

> ---
>   src/node_device/node_device_driver.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/node_device/node_device_driver.c b/src/node_device/node_device_driver.c
> index 4cf4e4214f..1d1eaa9561 100644
> --- a/src/node_device/node_device_driver.c
> +++ b/src/node_device/node_device_driver.c
> @@ -709,7 +709,7 @@ nodeDeviceGetMdevctlDefineStartCommand(virNodeDeviceDef *def,
>       g_autofree char *parent_addr = nodeDeviceFindAddressByName(def->parent);
>   
>       if (!parent_addr) {
> -        virReportError(VIR_ERR_NO_NODE_DEVICE,
> +        virReportError(VIR_ERR_INTERNAL_ERROR,
>                          _("unable to find parent device '%s'"), def->parent);
>           return NULL;
>       }
>